• Null User Object@lemmy.world
    link
    fedilink
    English
    arrow-up
    7
    arrow-down
    1
    ·
    2 days ago

    A refactoring would have a relatively similar number of subtractions as additions. This is almost entirely additions. This is not just refactoring.

    • EdTheMessenger@lemmy.world
      link
      fedilink
      English
      arrow-up
      8
      ·
      2 days ago

      Not necessarily. Huge additions without matching deletions often happen during restructurings like vendorizing dependencies, importing external packages, generating bindings, or migrating private repos into a monorepo. In these cases new code canbbe introduced to repository and there will be no corresponding deletions in commit history.

      I’ve did similar restructurings myself, eg. Making automatically generated resources static

      • northertech@fedia.io
        link
        fedilink
        arrow-up
        2
        arrow-down
        1
        ·
        1 day ago

        You have no idea what 11 million likes of code is do you? LibreOffice is 11m, Android is 12m, MySQL is 10m. Those projects took years to code not 9 months. I am going to have to ask you to stay in your lane, and I pray that is not Software Engineering.

        • EdTheMessenger@lemmy.world
          link
          fedilink
          English
          arrow-up
          1
          ·
          edit-2
          18 hours ago

          I’m not sure why you’re being so hostile, but you’re fundamentally confusing a codebase’s hand-written LoC with Git commit additions.

          Nobody is saying someone authored 11M lines. Commit fa3e8525 was a workspace reconciliation - importing external repository code, dependencies, and assets into the public repo for the first time, so exactly the type of thing I was talking about. Git counts all imported lines as additions.

          Before asking others to “stay in their lane”, maybe make sure you understand how Git history handles repository imports and dependency tracking. Have a good day.

      • Axolotl@feddit.it
        link
        fedilink
        English
        arrow-up
        3
        ·
        edit-2
        2 days ago

        Yeah, some projects also ditch external dependencies to make their own