I’ve done thousands of reviews, been a senior for the last 4 years, and a tech lead for three of those. If I could distill what I’ve learned into a few tips:
Make sure you understand what you know what they’re doing and why they’re doing it.
If something feels weird, explore it, your gut is a leading indicator of bad code.
Think about how you would know if there was something wrong with the code after its deployed.
Think about how hard it would be to change the code later on.
Those are probably my big ones for general code reviews, there’s more specific ones for v&v and embedded, but I feel like these apply to everything.
I’ve done thousands of reviews, been a senior for the last 4 years, and a tech lead for three of those. If I could distill what I’ve learned into a few tips:
Make sure you understand what you know what they’re doing and why they’re doing it.
If something feels weird, explore it, your gut is a leading indicator of bad code.
Think about how you would know if there was something wrong with the code after its deployed.
Think about how hard it would be to change the code later on.
Those are probably my big ones for general code reviews, there’s more specific ones for v&v and embedded, but I feel like these apply to everything.