If I was doing it as a way to acquire music to listen to, CDs, it’s easier and more convenient to rip them to a computer, they take up less storage space, and are more tolerant of a bit of neglect.

If I’m just looking to collect something for the sake of collecting something, probably vinyl.